Grasshopper_Toolkit - Issue 226 - Being able to input arrays #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epignatelli
changed the title
epignatelli
added
severity:critical
|
See BHoM/BHoM_UI#117 for comment |
adecler
added
the
status:do-not-merge
|
Closing this because of BHoM/BHoM_UI#117 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on BHoM/BHoM_UI#117
Issues addressed by this PR
Closes #226
Test files
Note that, even you need to use BHoM/BHoM_Engine#1124 to be able to input arrays, although it does not represent a code-wise dependency.
https://burohappold.sharepoint.com/:f:/s/BHoM/EjmxIfvj4WNBvi9qWzVvunoBwjYJX03lohJTTu8WHAxAhA?e=JpiJCu
Changelog
DataAccessor_GH.GetDataArray(int index)Additional comments
This pr is to support arrays (e.g.
int[]) as inputs from the visual programming interface. it does so by adding another getterGetDataArray(int).There are a series of cases that this does not solve voluntarily, where the arrays are nested, e.g.
List<int[]>